Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final vertex of 3DFACE not being added to entity vertex list when encountering a code other than 0 #112

Open
Vykaash opened this issue Aug 29, 2023 · 0 comments

Comments

@Vykaash
Copy link

Vykaash commented Aug 29, 2023

In some dxf, especially when revit is involved, data might be contained like the following:

3DFACE
... removed for brevity
 13
511577.6488682699
 23
1365679.835179607
 33
80.42828687855729
1001 <<<<< REVIT DATA - EXPECTED 0
REVIT

parse3DFaceVertices will collect 13,23,33 as expected but because the following code is 1001 instead of 0, it leaves the function without pushing that final vertex into vertices. due to this many quads end up as triangles.

I propose adding one final check for vertexIsStarted and pushing that vertex in so that quads will be formed properly.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant