Merge pull request #498 from gdsfactory/5122

meep and doe improvements
gdsfactory · Jun 29, 2022 · e049029 · e049029
2 parents 67136b2 + 42ab8df
commit e049029
Show file tree

Hide file tree

Showing 4 changed files with 82 additions and 63 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # [CHANGELOG](https://keepachangelog.com/en/1.0.0/)
 
+## [5.12.2](https://github.com/gdsfactory/gdsfactory/pull/494)
+
+- extract generating component list for doe into a separate function for use in pack_doe and elsewhere [fixes issue](https://github.com/gdsfactory/gdsfactory/issues/496)
+- meep 1.23 intoduced to use the energy in the whole simulation to determine when to terminate, which is a better termination condition than the energy at the ports. [PR](https://github.com/gdsfactory/gdsfactory/issues/496). Requires meep 1.23 or newer.
+
 ## [5.12.1](https://github.com/gdsfactory/gdsfactory/pull/494)
 
 - layer_stack has a 2.5D information.

diff --git a/docs/notebooks/plugins/meep/001_meep_sparameters.ipynb b/docs/notebooks/plugins/meep/001_meep_sparameters.ipynb
@@ -10,17 +10,22 @@
     "\n",
     "You to install meep and MPB with:\n",
     "\n",
+    "mamba (faster conda)\n",
     "\n",
-    "conda\n",
+    "```\n",
+    "mamba install pymeep=*=mpi_mpich_* -y\n",
+    "```\n",
+    "\n",
+    "conda (slower)\n",
     "\n",
     "```\n",
     "conda install -c conda-forge pymeep=*=mpi_mpich_* -y\n",
     "```\n",
     "\n",
-    "or mamba (faster conda)\n",
+    "To update you can use\n",
     "\n",
     "```\n",
-    "mamba install pymeep=*=mpi_mpich_* -y\n",
+    "mamba update pymeep=*=mpi_mpich_* -y\n",
     "```\n",
     "\n",
     "Works only on Mac, Linux or windows [WSL](https://docs.microsoft.com/en-us/windows/wsl/)\n",