New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crow coupler, labels on crow rings #1021
Conversation
simbilod
commented
Dec 19, 2022
- Crow variant with couplers
- All bends in crow components are labeled for easier access later (for instance to connect to actuators)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.37%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Somehow I cannot currently run the test to regenerate the component, I am getting ERROR - ImportError: numpy.core.multiarray failed to import |
bend2 = ring.add_ref(bend_c) | ||
bend3 = ring.add_ref(bend_c) | ||
bend4 = ring.add_ref(bend_c) | ||
bend1 = c.add_ref(bend_c, alias=f"bot_right_bend_ring_{index}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, thanks for the heads up I will take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed in a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!