Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crow coupler, labels on crow rings #1021

Merged
merged 1 commit into from Dec 20, 2022

Conversation

simbilod
Copy link
Collaborator

  • Crow variant with couplers
  • All bends in crow components are labeled for easier access later (for instance to connect to actuators)

image

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 19, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.37%.

Quality metrics Before After Change
Complexity 1.00 ⭐ 1.00 ⭐ 0.00
Method Length 144.67 😞 154.00 😞 9.33 👎
Working memory 14.76 😞 15.68 ⛔ 0.92 👎
Quality 46.67% 😞 45.30% 😞 -1.37% 👎
Other metrics Before After Change
Lines 121 123 2
Changed files Quality Before Quality After Quality Change
gdsfactory/components/ring_crow.py 46.67% 😞 45.30% 😞 -1.37% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/components/ring_crow.py ring_crow 1 ⭐ 377 ⛔ 17 ⛔ 40.40% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@simbilod
Copy link
Collaborator Author

Somehow I cannot currently run the test to regenerate the component, I am getting ERROR - ImportError: numpy.core.multiarray failed to import

@joamatab joamatab merged commit c4bc4d7 into gdsfactory:main Dec 20, 2022
bend2 = ring.add_ref(bend_c)
bend3 = ring.add_ref(bend_c)
bend4 = ring.add_ref(bend_c)
bend1 = c.add_ref(bend_c, alias=f"bot_right_bend_ring_{index}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the code

image

@simbilod

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, thanks for the heads up I will take a look

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed in a PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simbilod simbilod deleted the crow_coupler_labels branch January 3, 2023 01:51
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
crow coupler, labels on crow rings

Former-commit-id: ca98b2b [formerly c4bc4d7]
Former-commit-id: b77639e21559149542439ea459ef1fbe2a3282b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants