Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse empty polygons uz meshing #1023

Merged
merged 2 commits into from Dec 20, 2022

Conversation

simbilod
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 20, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.53%.

Quality metrics Before After Change
Complexity 7.99 ⭐ 8.00 ⭐ 0.01 👎
Method Length 91.85 🙂 93.46 🙂 1.61 👎
Working memory 11.80 😞 11.87 😞 0.07 👎
Quality 58.56% 🙂 58.03% 🙂 -0.53% 👎
Other metrics Before After Change
Lines 344 351 7
Changed files Quality Before Quality After Quality Change
gdsfactory/simulation/gmsh/parse_gds.py 72.14% 🙂 71.18% 🙂 -0.96% 👎
gdsfactory/simulation/gmsh/uz_xsection_mesh.py 49.70% 😞 49.39% 😞 -0.31% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/simulation/gmsh/uz_xsection_mesh.py uz_xsection_mesh 14 🙂 334 ⛔ 23 ⛔ 25.23% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmsh/parse_gds.py tile_shapes 21 😞 115 🙂 9 🙂 50.47% 🙂 Refactor to reduce nesting
gdsfactory/simulation/gmsh/uz_xsection_mesh.py get_uz_bounds_layers 3 ⭐ 138 😞 13 😞 56.04% 🙂 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmsh/parse_gds.py cleanup_component 5 ⭐ 98 🙂 10 😞 64.32% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1023 (2402b15) into main (c551aac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         436      436           
  Lines       22522    22522           
  Branches     2987     2987           
=======================================
  Hits        16485    16485           
  Misses       5144     5144           
  Partials      893      893           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 27e176c into gdsfactory:main Dec 20, 2022
@simbilod simbilod deleted the empty_layers_uz_meshing branch January 3, 2023 01:51
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
parse empty polygons uz meshing

Former-commit-id: f271344 [formerly 27e176c]
Former-commit-id: f9e19d9dd132399d1cd4b7bf134ab9d10e27ff6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants