Pn xs offset

[simbilod]

• fix pn cross section gap (was giving twice requested size)
• add argument to choose pn junction offset from waveguide center

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.03%.

Quality metrics	Before	After	Change
Complexity	5.67 ⭐	5.67 ⭐	0.00
Method Length	129.91 😞	130.87 😞	0.96 👎
Working memory	24.32 ⛔	24.51 ⛔	0.19 👎
Quality	49.56% 😞	49.53% 😞	-0.03% 👎

Other metrics	Before	After	Change
Lines	1283	1302	19

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/cross_section.py	49.56% 😞	49.53% 😞	-0.03% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/cross_section.py	pn	7 ⭐	503 ⛔	44 ⛔	27.01% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py	pn_ge_detector_si_contacts	7 ⭐	463 ⛔	45 ⛔	27.23% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py	rib_heater_doped_via_stack	8 ⭐	256 ⛔	28 ⛔	31.93% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py	pin	2 ⭐	237 ⛔	28 ⛔	38.78% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py	cross_section	4 ⭐	169 😞	38 ⛔	40.89% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1043 (d80d9b5) into main (5d6f97d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         436      436           
  Lines       22543    22543           
  Branches     2988     2988           
=======================================
  Hits        16361    16361           
  Misses       5305     5305           
  Partials      877      877           

Impacted Files	Coverage Δ
gdsfactory/cross_section.py	71.42% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[joamatab]

Thank you Simon!