Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple rows in straight_heater_meander #1046

Merged
merged 1 commit into from Dec 28, 2022

Conversation

simbilod
Copy link
Collaborator

@simbilod simbilod commented Dec 27, 2022

Fixed TODO in straight_heater_meander


    c = straight_heater_meander(
        straight_widths=(0.5,) * 7,
        taper_length=10,
        # taper_length=10,
        length=1000,
        # cross_section=gf.partial(gf.cross_section.strip, width=0.8),
    )
    c.show(show_ports=True)

image

EDIT: Is there a way for contributors to update gdslib and make the component tests pass in CI/CD?

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 27, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.66%.

Quality metrics Before After Change
Complexity 7.65 ⭐ 7.71 ⭐ 0.06 👎
Method Length 252.00 ⛔ 299.00 ⛔ 47.00 👎
Working memory 27.65 ⛔ 27.92 ⛔ 0.27 👎
Quality 30.07% 😞 29.41% 😞 -0.66% 👎
Other metrics Before After Change
Lines 201 226 25
Changed files Quality Before Quality After Quality Change
gdsfactory/components/straight_heater_meander.py 30.07% 😞 29.41% 😞 -0.66% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/components/straight_heater_meander.py straight_heater_meander 8 ⭐ 829 ⛔ 29 ⛔ 26.53% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab
Copy link
Contributor

Awesome! thank you Simon!

@joamatab joamatab merged commit 50f6da2 into gdsfactory:main Dec 28, 2022
@simbilod simbilod deleted the multirow_meander branch January 3, 2023 01:51
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
allow multiple rows in straight_heater_meander

Former-commit-id: c647242 [formerly 50f6da2]
Former-commit-id: 59e0a5e556188b9b982d3d0d5c23d171e48de4d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants