Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tidy3d #1064

Merged
merged 3 commits into from Jan 2, 2023
Merged

update tidy3d #1064

merged 3 commits into from Jan 2, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jan 2, 2023

  • update tidy3d from 1.8.0 to 1.8.1
  • fix write_sparameters_meep_mpi, after default read_metadata=False in import_gds

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #1064 (d2261cf) into main (b5725b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files         436      436           
  Lines       22570    22570           
  Branches     2993     2993           
=======================================
  Hits        16324    16324           
  Misses       5365     5365           
  Partials      881      881           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 2, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.14%.

Quality metrics Before After Change
Complexity 7.46 ⭐ 7.35 ⭐ -0.11 👍
Method Length 129.83 😞 130.83 😞 1.00 👎
Working memory 10.36 😞 10.28 😞 -0.08 👍
Quality 55.28% 🙂 55.42% 🙂 0.14% 👍
Other metrics Before After Change
Lines 379 387 8
Changed files Quality Before Quality After Quality Change
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py 76.23% ⭐ 75.87% ⭐ -0.36% 👎
gdsfactory/simulation/gmeep/write_sparameters_meep_mpi.py 33.63% 😞 33.63% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/simulation/gmeep/write_sparameters_meep_mpi.py write_sparameters_meep_mpi 18 🙂 455 ⛔ 19 ⛔ 22.45% ⛔ Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py test_sparameters_straight_batch 1 ⭐ 203 😞 6 ⭐ 66.27% 🙂 Try splitting into smaller methods
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py test_sparameters_lazy_parallelism 0 ⭐ 144 😞 5 ⭐ 75.21% ⭐ Try splitting into smaller methods
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py test_sparameters_straight_mpi 0 ⭐ 155 😞 4 ⭐ 76.67% ⭐ Try splitting into smaller methods
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py test_sparameters_straight_symmetric 0 ⭐ 150 😞 4 ⭐ 77.19% ⭐ Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit 4c3b62a into main Jan 2, 2023
@joamatab joamatab deleted the update_tidy3d branch January 2, 2023 19:10
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
update tidy3d

Former-commit-id: 8668ee8 [formerly 4c3b62a]
Former-commit-id: ae2e8187d80e49d3a10e30a5400535a78b4b77db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant