Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition also tapers cladding_layers and cladding offsets #1082

Merged
merged 2 commits into from Jan 4, 2023
Merged

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jan 4, 2023

fixes #1081

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 4, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 21.33 😞 20.87 😞 -0.46 👍
Method Length 126.34 😞 128.17 😞 1.83 👎
Working memory 14.72 😞 14.75 😞 0.03 👎
Quality 44.18% 😞 44.24% 😞 0.06% 👍
Other metrics Before After Change
Lines 1345 1360 15
Changed files Quality Before Quality After Quality Change
gdsfactory/path.py 44.18% 😞 44.24% 😞 0.06% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/path.py extrude 89 ⛔ 1024 ⛔ 28 ⛔ 1.52% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py transition 22 😞 446 ⛔ 20 ⛔ 19.02% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py _cut_path_with_ray 14 🙂 347 ⛔ 15 😞 30.84% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py euler 8 ⭐ 475 ⛔ 18 ⛔ 31.66% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py Path.__init__ 7 ⭐ 223 ⛔ 20 ⛔ 37.64% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit bce2ab5 into main Jan 4, 2023
@joamatab joamatab deleted the 6181 branch January 4, 2023 22:17
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
transition also tapers cladding_layers and cladding offsets

Former-commit-id: c04a09e [formerly bce2ab5]
Former-commit-id: 73a9119866468ec3ad90fcfa6ddc97b74ef41fde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

taper_cross_section_linear does not taper cladding
1 participant