Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose plot options in meep solver #1122

Merged
merged 1 commit into from Jan 10, 2023

Conversation

simbilod
Copy link
Collaborator

@simbilod simbilod commented Jan 9, 2023

default behaviour is preserved

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 9, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 4.38%.

Quality metrics Before After Change
Complexity 34.34 ⛔ 47.42 ⛔ 13.08 👎
Method Length 294.60 ⛔ 252.33 ⛔ -42.27 👍
Working memory 2.78 ⭐ 2.57 ⭐ -0.21 👍
Quality 25.48% 😞 21.10% -4.38% 👎
Other metrics Before After Change
Lines 527 537 10
Changed files Quality Before Quality After Quality Change
gdsfactory/simulation/gmeep/write_sparameters_meep.py 25.48% 😞 21.10% ⛔ -4.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/simulation/gmeep/write_sparameters_meep.py write_sparameters_meep 66 ⛔ 1022 ⛔ 1.87% ⛔ Refactor to reduce nesting. Try splitting into smaller methods
gdsfactory/simulation/gmeep/write_sparameters_meep.py parse_port_eigenmode_coeff 6 ⭐ 177 😞 13 😞 49.16% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #1122 (78571c1) into main (b46e362) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   72.95%   72.95%           
=======================================
  Files         449      449           
  Lines       22655    22658    +3     
  Branches     3012     3012           
=======================================
+ Hits        16527    16530    +3     
  Misses       5223     5223           
  Partials      905      905           
Impacted Files Coverage Δ
gdsfactory/labels/write_labels.py 93.75% <0.00%> (ø)
gdsfactory/components/optimal_step.py 66.21% <0.00%> (ø)
gdsfactory/types.py 85.60% <0.00%> (+0.10%) ⬆️
gdsfactory/config.py 72.09% <0.00%> (+0.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab
Copy link
Contributor

Thank you Simon!

@joamatab joamatab merged commit 6b8a101 into gdsfactory:main Jan 10, 2023
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
expose plot options in meep solver

Former-commit-id: b636bf2 [formerly 6b8a101]
Former-commit-id: 8ed9cf34dfc6966344d5f0b1431881a99fdee3b6
@simbilod simbilod deleted the meep_visualization branch April 5, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants