Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interdigital capacitor #1167

Merged
merged 1 commit into from Jan 17, 2023

Conversation

nikosavola
Copy link
Member

This PR implements an interdigital capacitor component with parametrisation for

  • amount of fingers
    • length
    • gap
    • thickness

Also, using finger_length=0, one gets a plate capacitor

image

@joamatab, could you check if there's anything missing in the component definition here?

Part of #610

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 17, 2023

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 3.00 ⭐ 3.00 ⭐ 0.00
Method Length 1937.00 ⛔ 1934.00 ⛔ -3.00 👍
Working memory 36.00 ⛔ 36.00 ⛔ 0.00
Quality 30.68% 😞 30.68% 😞 0.00%
Other metrics Before After Change
Lines 560 556 -4
Changed files Quality Before Quality After Quality Change
gdsfactory/components/__init__.py 30.68% 😞 30.68% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab
Copy link
Contributor

Looks great, thank you Niko!

@joamatab joamatab merged commit 50b5696 into gdsfactory:main Jan 17, 2023
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
…apacitor

Add interdigital capacitor

Former-commit-id: 827ffa2 [formerly 50b5696]
Former-commit-id: 06f94d105b5ae8a0f8b8b3665d1a18d85309d905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants