options for 3D meshing

[simbilod]

No description provided.

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 4.72%.

Quality metrics	Before	After	Change
Complexity	12.94 🙂	17.56 🙂	4.62 👎
Method Length	143.60 😞	152.50 😞	8.90 👎
Working memory	12.88 😞	14.03 😞	1.15 👎
Quality	42.17% 😞	37.45% 😞	-4.72% 👎

Other metrics	Before	After	Change
Lines	396	417	21

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/simulation/gmsh/xyz_mesh.py	42.17% 😞	37.45% 😞	-4.72% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/simulation/gmsh/xyz_mesh.py	xyz_mesh	30 😞	678 ⛔	17 ⛔	15.95% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmsh/xyz_mesh.py	add_volume	10 🙂	325 ⛔	15 😞	34.89% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmsh/xyz_mesh.py	add_volume_with_holes	3 ⭐	94 🙂	11 😞	64.95% 🙂	Extract out complex expressions
gdsfactory/simulation/gmsh/xyz_mesh.py	channel_loop_from_vertices	1 ⭐	61 ⭐	10 😞	73.75% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1207 (38df882) into main (019d0ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files         454      454           
  Lines       23067    23067           
  Branches     3061     3061           
=======================================
  Hits        16812    16812           
  Misses       5366     5366           
  Partials      889      889           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more