max points to 4e3

[joamatab]

• default max points to 4e3
• use constants in pdk

@tvt173

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.43%.

Quality metrics	Before	After	Change
Complexity	7.01 ⭐	7.24 ⭐	0.23 👎
Method Length	66.45 🙂	67.32 🙂	0.87 👎
Working memory	7.83 🙂	7.92 🙂	0.09 👎
Quality	65.30% 🙂	64.87% 🙂	-0.43% 👎

Other metrics	Before	After	Change
Lines	3006	3054	48

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/component.py	65.40% 🙂	64.87% 🙂	-0.53% 👎
gdsfactory/pdk.py	65.83% 🙂	65.81% 🙂	-0.02% 👎
gdsfactory/write_cells.py	59.56% 🙂	59.33% 🙂	-0.23% 👎
gdsfactory/generic_tech/__init__.py	82.92% ⭐	82.33% ⭐	-0.59% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/component.py	Component._write_library	25 😞	402 ⛔	19 ⛔	18.24% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py	flatten_invalid_refs_recursive	20 😞	325 ⛔		27.26% 😞	Refactor to reduce nesting. Try splitting into smaller methods
gdsfactory/pdk.py	Pdk._get_component	22 😞	255 ⛔	14 😞	29.14% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py	Component.plot_holoviews	14 🙂	475 ⛔	12 😞	33.50% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py	Component.add_polygon	18 🙂	282 ⛔	12 😞	33.79% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1254 (5879dab) into main (e45404d) will decrease coverage by 0.02%.
The diff coverage is 47.05%.

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   68.78%   68.77%   -0.02%     
==========================================
  Files         356      356              
  Lines       21175    21185      +10     
  Branches     3039     3041       +2     
==========================================
+ Hits        14566    14570       +4     
- Misses       5752     5758       +6     
  Partials      857      857              

Impacted Files	Coverage Δ
gdsfactory/pdk.py	55.32% <ø> (ø)
gdsfactory/write_cells.py	72.94% <0.00%> (-5.54%)	⬇️
gdsfactory/component.py	68.38% <77.77%> (+0.13%)	⬆️
gdsfactory/generic_tech/__init__.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more