Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document Component.get_ports_pandas() #1308

Merged
merged 4 commits into from Feb 19, 2023
Merged

document Component.get_ports_pandas() #1308

merged 4 commits into from Feb 19, 2023

Conversation

joamatab
Copy link
Contributor

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 19, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.04%.

Quality metrics Before After Change
Complexity 6.93 ⭐ 6.92 ⭐ -0.01 👍
Method Length 66.61 🙂 66.98 🙂 0.37 👎
Working memory 8.22 🙂 8.20 🙂 -0.02 👍
Quality 66.02% 🙂 65.98% 🙂 -0.04% 👎
Other metrics Before After Change
Lines 2466 2483 17
Changed files Quality Before Quality After Quality Change
gdsfactory/component.py 66.02% 🙂 65.98% 🙂 -0.04% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/component.py Component._write_library 25 😞 459 ⛔ 17 ⛔ 19.32% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.plot_holoviews 14 🙂 475 ⛔ 12 😞 33.50% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.add_polygon 18 🙂 282 ⛔ 12 😞 33.79% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.remap_layers 29 😞 216 ⛔ 10 😞 33.89% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py flatten_invalid_refs_recursive 22 😞 191 😞 11 😞 37.93% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit 6c13381 into main Feb 19, 2023
@joamatab joamatab deleted the 643port_pandas branch February 19, 2023 22:44
simbilod pushed a commit to simbilod/gdsfactory that referenced this pull request Mar 2, 2023
document `Component.get_ports_pandas()`

Former-commit-id: 925bebf [formerly 6c13381]
Former-commit-id: e467821dff286d936dc0f7539b308c65f4e3cf82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant