Lumerical booleans

[joamatab]

make sure derived layers also work with Lumerical FDTD plugin

[sourcery-ai]

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	29.87 😞	29.87 😞	0.00
Method Length	193.70 😞	194.10 😞	0.40 👎
Working memory	24.04 ⛔	24.04 ⛔	0.00
Quality	24.23% ⛔	24.23% ⛔	0.00%

Other metrics	Before	After	Change
Lines	602	602	0

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/simulation/lumerical/write_sparameters_lumerical.py	18.44% ⛔	18.44% ⛔	0.00%
gdsfactory/technology/simulation_settings.py	80.34% ⭐	80.34% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/simulation/lumerical/write_sparameters_lumerical.py	write_sparameters_lumerical	39 ⛔	1411 ⛔	30 ⛔	6.73% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/lumerical/write_sparameters_lumerical.py	set_material	7 ⭐	144 😞	9 🙂	58.73% 🙂	Try splitting into smaller methods
gdsfactory/simulation/lumerical/write_sparameters_lumerical.py	_sample_write_coupler_ring	0 ⭐	50 ⭐	10 😞	76.49% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!