Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install uses copy instead of symlink #1375

Merged
merged 9 commits into from Mar 2, 2023
Merged

install uses copy instead of symlink #1375

merged 9 commits into from Mar 2, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Mar 2, 2023

  • install uses copy instead of symlink if symlink fails
  • add gf.cross_section.rib_with_trenches
  • use python instead of jupyter notebooks to build docs
  • logger does not automatically print the version of the tool
  • gf --version prints all plugin versions

@thomasdorch

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 2, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.43%.

Quality metrics Before After Change
Complexity 2.62 ⭐ 2.58 ⭐ -0.04 👍
Method Length 93.81 🙂 92.31 🙂 -1.50 👍
Working memory 15.20 ⛔ 15.06 😞 -0.14 👍
Quality 59.37% 🙂 59.80% 🙂 0.43% 👍
Other metrics Before After Change
Lines 3158 3257 99
Changed files Quality Before Quality After Quality Change
docs/notebooks/08_pdk.py 52.85% 🙂 52.85% 🙂 0.00%
docs/notebooks/09_pdk_import.py 57.26% 🙂 57.26% 🙂 0.00%
gdsfactory/cli.py 84.96% ⭐ 82.60% ⭐ -2.36% 👎
gdsfactory/config.py 79.47% ⭐ 81.32% ⭐ 1.85% 👍
gdsfactory/cross_section.py 49.74% 😞 50.03% 🙂 0.29% 👍
gdsfactory/install.py 75.26% ⭐ 77.29% ⭐ 2.03% 👍
gdsfactory/klive.py 75.73% ⭐ 75.73% ⭐ 0.00%
gdsfactory/components/spiral_double.py 60.09% 🙂 60.09% 🙂 0.00%
gdsfactory/geometry/offset.py 63.11% 🙂 63.11% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/cross_section.py pn_with_trenches 7 ⭐ 508 ⛔ 47 ⛔ 26.95% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py pn 7 ⭐ 477 ⛔ 45 ⛔ 27.13% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py pn_ge_detector_si_contacts 7 ⭐ 424 ⛔ 43 ⛔ 27.59% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py rib_heater_doped_via_stack 8 ⭐ 254 ⛔ 27 ⛔ 32.23% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/cross_section.py cross_section 4 ⭐ 179 😞 39 ⛔ 39.95% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1375 (38e33ec) into main (4b367fa) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head 38e33ec differs from pull request most recent head c957eb0. Consider uploading reports for the commit c957eb0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
- Coverage   69.68%   69.67%   -0.01%     
==========================================
  Files         366      366              
  Lines       21828    21832       +4     
  Branches     3127     3127              
==========================================
+ Hits        15210    15211       +1     
- Misses       5718     5721       +3     
  Partials      900      900              
Impacted Files Coverage Δ
gdsfactory/components/spiral_double.py 100.00% <ø> (ø)
gdsfactory/geometry/offset.py 77.77% <ø> (ø)
gdsfactory/install.py 19.51% <0.00%> (-0.49%) ⬇️
gdsfactory/cross_section.py 66.01% <33.33%> (-0.56%) ⬇️
gdsfactory/config.py 65.34% <50.00%> (-0.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit c035624 into main Mar 2, 2023
@joamatab joamatab deleted the rib_with_trenches branch March 2, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant