Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow choosing femwell solver #1377

Merged
merged 2 commits into from Mar 2, 2023
Merged

allow choosing femwell solver #1377

merged 2 commits into from Mar 2, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Mar 2, 2023

  • allow choosing femwell solver
  • rename wl to wavelength to be consistent with other plugins

@simbilod
@HelgeGehring

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 2, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.18%.

Quality metrics Before After Change
Complexity 8.53 🙂 8.53 🙂 0.00
Method Length 108.58 🙂 108.80 🙂 0.22 👎
Working memory 11.09 😞 11.32 😞 0.23 👎
Quality 55.53% 🙂 55.35% 🙂 -0.18% 👎
Other metrics Before After Change
Lines 1353 1355 2
Changed files Quality Before Quality After Quality Change
gdsfactory/simulation/fem/mode_solver.py 39.58% 😞 39.27% 😞 -0.31% 👎
gdsfactory/technology/layer_views.py 58.37% 🙂 58.21% 🙂 -0.16% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/simulation/fem/mode_solver.py compute_component_slice_modes 18 🙂 348 ⛔ 27 ⛔ 20.50% ⛔ Try splitting into smaller methods. Extract out complex expressions
gdsfactory/technology/layer_views.py LayerView._build_klayout_xml_element 17 🙂 359 ⛔ 16 ⛔ 27.05% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/technology/layer_views.py LayerViews.from_lyp 18 🙂 273 ⛔ 11 😞 35.89% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/technology/layer_views.py LayerView.from_xml_element 13 🙂 277 ⛔ 11 😞 39.78% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/technology/layer_views.py LayerViews.__init__ 14 🙂 212 ⛔ 12 😞 40.68% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1377 (e58c04c) into main (a3125a4) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage   69.66%   69.66%           
=======================================
  Files         366      366           
  Lines       21844    21844           
  Branches     3128     3128           
=======================================
  Hits        15218    15218           
  Misses       5726     5726           
  Partials      900      900           
Impacted Files Coverage Δ
gdsfactory/technology/layer_views.py 41.47% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 8463035 into main Mar 2, 2023
@joamatab joamatab deleted the femwell_improvements branch March 2, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant