Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidewall tolerance #1382

Merged
merged 2 commits into from Mar 3, 2023
Merged

Conversation

mdecea
Copy link
Collaborator

@mdecea mdecea commented Mar 3, 2023

Adding support for sidewall tolerance in LayerLevel

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 3, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.17%.

Quality metrics Before After Change
Complexity 28.43 😞 28.26 😞 -0.17 👍
Method Length 120.08 😞 120.33 😞 0.25 👎
Working memory 17.12 ⛔ 17.07 ⛔ -0.05 👍
Quality 34.91% 😞 35.08% 😞 0.17% 👍
Other metrics Before After Change
Lines 364 366 2
Changed files Quality Before Quality After Quality Change
gdsfactory/technology/layer_stack.py 34.91% 😞 35.08% 😞 0.17% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/technology/layer_stack.py LayerStack.get_klayout_3d_script 52 ⛔ 695 ⛔ 26 ⛔ 4.53% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/technology/layer_stack.py LayerStack.get_component_with_derived_layers 15 🙂 323 ⛔ 13 😞 33.26% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1382 (be46e8f) into main (a18f327) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         366      366           
  Lines       21852    21853    +1     
  Branches     3130     3130           
=======================================
+ Hits        15218    15219    +1     
  Misses       5734     5734           
  Partials      900      900           
Impacted Files Coverage Δ
gdsfactory/technology/layer_stack.py 59.19% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab
Copy link
Contributor

joamatab commented Mar 3, 2023

Thank you Marc!

@joamatab joamatab merged commit e0b85ba into gdsfactory:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants