Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fill_rectangle_custom #1392

Merged
merged 1 commit into from Mar 4, 2023
Merged

add fill_rectangle_custom #1392

merged 1 commit into from Mar 4, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Mar 4, 2023

  • add gf.fill.fill_rectangle_custom which allows you to fill a region with a custom cell

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 4, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.45%.

Quality metrics Before After Change
Complexity 5.89 ⭐ 6.36 ⭐ 0.47 👎
Method Length 127.00 😞 137.31 😞 10.31 👎
Working memory 10.06 😞 10.42 😞 0.36 👎
Quality 56.47% 🙂 54.02% 🙂 -2.45% 👎
Other metrics Before After Change
Lines 437 489 52
Changed files Quality Before Quality After Quality Change
gdsfactory/__init__.py 89.96% ⭐ 89.90% ⭐ -0.06% 👎
gdsfactory/fill.py 53.95% 🙂 51.83% 🙂 -2.12% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/fill.py fill_rectangle 13 🙂 383 ⛔ 14 😞 32.30% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/fill.py fill_rectangle_custom 8 ⭐ 249 ⛔ 12 😞 43.85% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/fill.py _rasterize_polygons 3 ⭐ 217 ⛔ 10 😞 54.21% 🙂 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/fill.py fill_cell_rectangle 4 ⭐ 136 😞 10 😞 60.48% 🙂 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/fill.py _expand_raster 3 ⭐ 123 😞 10 😞 63.02% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1392 (70b19a8) into main (7273399) will decrease coverage by 0.07%.
The diff coverage is 22.58%.

@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
- Coverage   69.49%   69.42%   -0.07%     
==========================================
  Files         366      366              
  Lines       21913    21942      +29     
  Branches     3141     3150       +9     
==========================================
+ Hits        15229    15234       +5     
- Misses       5781     5805      +24     
  Partials      903      903              
Impacted Files Coverage Δ
gdsfactory/fill.py 66.20% <20.00%> (-12.43%) ⬇️
gdsfactory/__init__.py 94.11% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 8e60812 into main Mar 4, 2023
@joamatab joamatab deleted the 655 branch March 4, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant