Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add angle parameter to ring component #1407

Merged
merged 1 commit into from Mar 10, 2023
Merged

Conversation

simbilod
Copy link
Collaborator

@simbilod simbilod commented Mar 9, 2023

parameter to control angle coverage of a ring

@mdecea

image

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 9, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.08%.

Quality metrics Before After Change
Complexity 0.18 ⭐ 0.18 ⭐ 0.00
Method Length 65.33 🙂 68.00 🙂 2.67 👎
Working memory 9.41 🙂 11.06 😞 1.65 👎
Quality 68.42% 🙂 65.34% 🙂 -3.08% 👎
Other metrics Before After Change
Lines 39 41 2
Changed files Quality Before Quality After Quality Change
gdsfactory/components/ring.py 68.42% 🙂 65.34% 🙂 -3.08% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/components/ring.py ring 0 ⭐ 142 😞 13 😞 58.59% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit 8007092 into gdsfactory:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants