Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cutback_2x2 #1422

Merged
merged 3 commits into from Mar 14, 2023
Merged

Improve cutback_2x2 #1422

merged 3 commits into from Mar 14, 2023

Conversation

SkandanC
Copy link
Contributor

Improve cutback_2x2.

Closes #1373

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 13, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 41.22%.

Quality metrics Before After Change
Complexity 0.20 ⭐ 14.07 🙂 13.87 👎
Method Length 57.67 ⭐ 191.00 😞 133.33 👎
Working memory 12.60 😞 24.40 ⛔ 11.80 👎
Quality 67.70% 🙂 26.48% 😞 -41.22% 👎
Other metrics Before After Change
Lines 51 116 65
Changed files Quality Before Quality After Quality Change
gdsfactory/components/cutback_2x2.py 67.70% 🙂 26.48% 😞 -41.22% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/components/cutback_2x2.py cutback_2x2 15 🙂 483 ⛔ 26 ⛔ 21.49% ⛔ Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab
Copy link
Contributor

Thank you Skandan!

@joamatab joamatab merged commit a69e720 into gdsfactory:main Mar 14, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve cutback2x2
2 participants