Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure via stack fits at least one via #1461

Merged
merged 1 commit into from Mar 22, 2023
Merged

make sure via stack fits at least one via #1461

merged 1 commit into from Mar 22, 2023

Conversation

joamatab
Copy link
Contributor

fixes #1460

Thank you Marc

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 22, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.38%.

Quality metrics Before After Change
Complexity 10.50 🙂 12.14 🙂 1.64 👎
Method Length 192.50 😞 197.67 😞 5.17 👎
Working memory 15.31 ⛔ 16.17 ⛔ 0.86 👎
Quality 39.03% 😞 36.65% 😞 -2.38% 👎
Other metrics Before After Change
Lines 266 272 6
Changed files Quality Before Quality After Quality Change
gdsfactory/components/via_stack.py 39.03% 😞 36.65% 😞 -2.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/components/via_stack.py via_stack 18 🙂 385 ⛔ 20 ⛔ 22.55% ⛔ Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/via_stack.py via_stack_from_rules 14 🙂 386 ⛔ 18 ⛔ 27.16% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/via_stack.py optimized_via 3 ⭐ 103 🙂 11 😞 63.71% 🙂 Extract out complex expressions
gdsfactory/components/via_stack.py test_via_stack_from_rules 0 ⭐ 136 😞 9 🙂 66.52% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit 8dbe74d into main Mar 22, 2023
8 checks passed
@joamatab joamatab deleted the 6653 branch March 22, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating vias without checks can cause errors and even segmentation faults
1 participant