New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some changes to section based ring and ViaStacks #1475
Conversation
…op, and different gaps
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 5.84%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Always good to have more flexibility! Seems like a good check for the vias. If there is freedom in choosing via size we also have def via_stack_from_rules( |
great, thank you Marc! |
Modified section based rings so that they can have diffferent add/drop gaps and different cross sections before and after the drop port. @simbilod I don't think this affects you but might be worth taking a quick look.
Made ViaStack accept a parameter that tells if we want to get an error when the via is too small, or simply adjust the sizes to make them work. @joamatab What do you think?