Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirroring drop waveguide for asymmetric waveguides in section based ring #1498

Merged
merged 3 commits into from Mar 29, 2023

Conversation

mdecea
Copy link
Collaborator

@mdecea mdecea commented Mar 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1498 (676be52) into main (cb3c645) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   68.44%   68.45%           
=======================================
  Files         375      375           
  Lines       22953    22952    -1     
  Branches     3331     3331           
=======================================
  Hits        15711    15711           
+ Misses       6308     6307    -1     
  Partials      934      934           
Impacted Files Coverage Δ
gdsfactory/components/ring_section_based.py 10.71% <0.00%> (ø)
gdsfactory/cross_section.py 52.38% <ø> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit cff5cf5 into gdsfactory:main Mar 29, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants