Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer views update #1518

Merged
merged 3 commits into from Apr 2, 2023
Merged

Conversation

thomasdorch
Copy link
Contributor

This PR improves the LayerViews xml import to handle when fields are undefined. Also, it will no longer write empty CustomDitherPatterns and CustomLineStyles fields to the yaml.

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #1518 (fcd4eea) into main (a57fe6e) will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   68.47%   68.45%   -0.03%     
==========================================
  Files         376      376              
  Lines       22980    22984       +4     
  Branches     3330     3333       +3     
==========================================
- Hits        15735    15733       -2     
- Misses       6309     6314       +5     
- Partials      936      937       +1     
Impacted Files Coverage Δ
gdsfactory/technology/klayout_tech.py 27.94% <0.00%> (ø)
gdsfactory/technology/layer_views.py 40.14% <20.00%> (-0.91%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 4568fc5 into gdsfactory:main Apr 2, 2023
8 of 10 checks passed
@thomasdorch thomasdorch deleted the layer-views-update branch November 30, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants