Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better greek cross #1561

Merged
merged 3 commits into from Apr 19, 2023
Merged

Better greek cross #1561

merged 3 commits into from Apr 19, 2023

Conversation

simbilod
Copy link
Collaborator

@simbilod simbilod commented Apr 19, 2023

also add the version with pads for quick pcm

image

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #1561 (6199c85) into main (a974dbf) will decrease coverage by 0.08%.
The diff coverage is 57.57%.

@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   67.71%   67.63%   -0.08%     
==========================================
  Files         380      380              
  Lines       23286    23318      +32     
  Branches     3366     3371       +5     
==========================================
+ Hits        15767    15772       +5     
- Misses       6580     6608      +28     
+ Partials      939      938       -1     
Impacted Files Coverage Δ
gdsfactory/components/greek_cross.py 45.90% <57.57%> (-54.10%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit e7aacea into gdsfactory:main Apr 19, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants