Modesolver update2 #1628
Merged
Modesolver update2 #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all features from the previous solver are available in some form. We're missing the implementation of the index dictionary that was overlaid in the previous version to enable the user to set a non homogeneous index profile over the geometry. That can be enabled through `CustomMedium` in the future. There are a few improvements from the previous version, most notably the use of a non-uniform grid. This commit solves issues from both #1056 and flexcompute/tidy3d#652. Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Codecov Report
@@ Coverage Diff @@
## main #1628 +/- ##
=======================================
Coverage 68.65% 68.65%
=======================================
Files 375 375
Lines 23102 23102
Branches 3377 3377
=======================================
Hits 15860 15860
Misses 6303 6303
Partials 939 939 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tidy3d mode solver to use adaptative meshing
@lucas-flexcompute
@simbilod
@HelgeGehring
@flaport