Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pins and flatten_invalid_refs #1674

Merged
merged 2 commits into from May 19, 2023
Merged

Conversation

joamatab
Copy link
Contributor

  • flatten_invalid_refs = True by default
  • strip has pins of 1nm to check connectivity checks
  • all angle router width wide = 0.9 to match with_wide

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1674 (ea2e289) into main (c62f3ec) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
+ Coverage   68.40%   68.46%   +0.06%     
==========================================
  Files         377      377              
  Lines       23287    23287              
  Branches     3401     3401              
==========================================
+ Hits        15929    15943      +14     
+ Misses       6414     6400      -14     
  Partials      944      944              
Impacted Files Coverage Δ
gdsfactory/components/mzi.py 93.82% <ø> (ø)
gdsfactory/pdk.py 57.01% <ø> (ø)
gdsfactory/routing/all_angle.py 83.59% <ø> (ø)
gdsfactory/component.py 62.18% <100.00%> (-0.19%) ⬇️
gdsfactory/cross_section.py 53.63% <100.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 863572c into main May 19, 2023
10 checks passed
@joamatab joamatab deleted the add_pins_and_flatten_invalid_refs branch May 19, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant