Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair symmetries for Tidy3D #1683

Merged
merged 1 commit into from May 21, 2023
Merged

Conversation

jan-david-fischbach
Copy link
Collaborator

fixes #1681

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #1683 (56dcb31) into main (cc4d4c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   68.43%   68.43%           
=======================================
  Files         377      377           
  Lines       23301    23301           
  Branches     3402     3402           
=======================================
  Hits        15946    15946           
  Misses       6411     6411           
  Partials      944      944           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab
Copy link
Contributor

Thank you jan-David

@joamatab joamatab merged commit 3036039 into gdsfactory:main May 21, 2023
8 of 10 checks passed
@joamatab
Copy link
Contributor

Thank you Jan David!

@jan-david-fischbach
Copy link
Collaborator Author

My Pre-Commits seem broken and I didn't notice, sorry.

@joamatab
Copy link
Contributor

it's okay, just fixed them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port_symmetries on gtidy3d.write_sparameters seem broken
2 participants