Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix snapping #1685

Merged
merged 2 commits into from May 22, 2023
Merged

fix snapping #1685

merged 2 commits into from May 22, 2023

Conversation

joamatab
Copy link
Contributor

remove snapping in waveguides to fix 1nm snapping issues

fixes #1666

now it works as as charm! thank you Troy!
@tvt173

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #1685 (8829142) into main (ab6e7d0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1685      +/-   ##
==========================================
- Coverage   68.40%   68.40%   -0.01%     
==========================================
  Files         377      377              
  Lines       23312    23310       -2     
  Branches     3404     3404              
==========================================
- Hits        15947    15945       -2     
  Misses       6421     6421              
  Partials      944      944              
Impacted Files Coverage Δ
gdsfactory/components/straight.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit b86018b into main May 22, 2023
8 of 10 checks passed
@joamatab joamatab deleted the fix_snapping branch May 22, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1nm snapping issues
1 participant