Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klive handshake docs py2 #1796

Merged
merged 19 commits into from Jun 22, 2023
Merged

Klive handshake docs py2 #1796

merged 19 commits into from Jun 22, 2023

Conversation

joamatab
Copy link
Contributor

  • adds klive handshake for more reliable
  • prints warning when running component.show() and klayout is not open
  • allows to delete file after showing it
  • organize notebooks in flat structure

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1796 (1f87b9f) into main (401369a) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
- Coverage   68.43%   68.41%   -0.03%     
==========================================
  Files         374      374              
  Lines       23574    23584      +10     
  Branches     3413     3414       +1     
==========================================
+ Hits        16133    16135       +2     
- Misses       6488     6495       +7     
- Partials      953      954       +1     
Impacted Files Coverage Δ
gdsfactory/add_loopback.py 26.66% <ø> (ø)
gdsfactory/klive.py 54.83% <25.00%> (-16.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 13725c2 into main Jun 22, 2023
8 of 10 checks passed
@joamatab joamatab deleted the klive_handshake_docs_py2 branch June 22, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant