Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plot jupyter #1802

Merged
merged 2 commits into from Jun 23, 2023
Merged

Improve plot jupyter #1802

merged 2 commits into from Jun 23, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jun 23, 2023

  • improve plot_jupyter. Now it starts server if it does not exist.
  • Make gf.CONF.display_type= 'kweb' by default
  • Update kweb version in pyproject.
  • fix gf init notebooks.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1802 (c36e61e) into main (13725c2) will decrease coverage by 0.03%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
- Coverage   68.41%   68.38%   -0.03%     
==========================================
  Files         374      374              
  Lines       23584    23593       +9     
  Branches     3414     3417       +3     
==========================================
  Hits        16135    16135              
- Misses       6495     6504       +9     
  Partials      954      954              
Impacted Files Coverage Δ
gdsfactory/cli.py 67.17% <0.00%> (ø)
gdsfactory/component.py 61.47% <0.00%> (-0.53%) ⬇️
gdsfactory/install.py 22.58% <40.00%> (ø)
gdsfactory/config.py 57.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 29f8bd0 into main Jun 23, 2023
8 of 10 checks passed
@joamatab joamatab deleted the improve_plot_jupyter branch June 23, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant