Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix via stack port orientations #1844

Merged
merged 4 commits into from Jul 8, 2023
Merged

Fix via stack port orientations #1844

merged 4 commits into from Jul 8, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jul 8, 2023

  • fix Component.auto_rename ports to also auto-rename ports of port_type='placement'. Fixes Via port inconsistency #1838
  • default port_type = 'placement' 'electrical' for most cases
  • add all ports in straight heater. Adding prefixes l for left and r for right

@simbilod
@EliDoris

@simbilod
Copy link
Collaborator

simbilod commented Jul 8, 2023

Amazing thanks Joaquin!

@joamatab joamatab merged commit 69342fe into main Jul 8, 2023
8 checks passed
@joamatab joamatab deleted the fix_via_stack_port_orientations branch July 8, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Via port inconsistency
2 participants
@joamatab @simbilod