Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto name cross sections #2119

Closed
wants to merge 3 commits into from
Closed

Auto name cross sections #2119

wants to merge 3 commits into from

Conversation

joamatab
Copy link
Contributor

fixes issue #2089

now it should work even without defining the name

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2119 (b154d42) into main (0db0674) will decrease coverage by 0.20%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
- Coverage   70.63%   70.44%   -0.20%     
==========================================
  Files         368      368              
  Lines       23078    23066      -12     
  Branches     3431     3431              
==========================================
- Hits        16302    16249      -53     
- Misses       5739     5778      +39     
- Partials     1037     1039       +2     
Files Changed Coverage Δ
gdsfactory/components/bend_s.py 82.97% <ø> (ø)
gdsfactory/components/bezier.py 86.84% <ø> (ø)
gdsfactory/components/mzi.py 93.75% <ø> (ø)
gdsfactory/components/splitter_chain.py 100.00% <ø> (ø)
gdsfactory/components/straight.py 100.00% <ø> (ø)
gdsfactory/components/straight_heater_doped_rib.py 81.08% <ø> (ø)
gdsfactory/routing/all_angle.py 81.49% <ø> (ø)
gdsfactory/cross_section.py 50.09% <85.71%> (-3.98%) ⬇️
gdsfactory/components/add_trenches.py 86.66% <100.00%> (ø)
gdsfactory/components/disk.py 81.05% <100.00%> (ø)
... and 4 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab closed this Sep 25, 2023
@joamatab joamatab deleted the auto_name_cross_sections branch October 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant