Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdsfactory78 #2124

Merged
merged 7 commits into from Sep 25, 2023
Merged

Gdsfactory78 #2124

merged 7 commits into from Sep 25, 2023

Conversation

joamatab
Copy link
Contributor

  • fixes name issue issue with gf.path.transition() ports position #2089
  • adds CONF.enforce_ports_on_grid flag that allows you to create offgrid ports fixes grid snapping fixes #2118
  • simplify CrossSection so that it's serializable.
  • simplify Transition, it does not inherit from CrossSection
  • create separate gf.path.extrude_transition
  • remove A-star router from docs as it's an experimental feature, not ready for use
  • remove **kwargs from many components
  • add warnings for off-grid-ports and non-manhattan ports (0, 90, 180, 270)
  • add CrossSection.validate_radius
  • pin pydantic min version <2.4

This will be a minor release gdsfactory 7.8.0

@sebastian-goeldi
@tvt173
@SkandanC
@yaugenst
@simbilod

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2124 (ff878d8) into main (0db0674) will increase coverage by 0.84%.
The diff coverage is 86.34%.

@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
+ Coverage   70.63%   71.48%   +0.84%     
==========================================
  Files         368      368              
  Lines       23078    22986      -92     
  Branches     3431     3374      -57     
==========================================
+ Hits        16302    16431     +129     
+ Misses       5739     5550     -189     
+ Partials     1037     1005      -32     
Files Coverage Δ
gdsfactory/__init__.py 100.00% <100.00%> (ø)
gdsfactory/add_tapers_cross_section.py 47.82% <ø> (ø)
gdsfactory/cell.py 67.39% <100.00%> (+1.46%) ⬆️
gdsfactory/component.py 63.14% <100.00%> (-2.18%) ⬇️
gdsfactory/component_reference.py 74.73% <ø> (ø)
.../add_fiber_array_optical_south_electrical_north.py 97.29% <ø> (ø)
gdsfactory/components/add_grating_couplers.py 78.65% <100.00%> (-0.13%) ⬇️
gdsfactory/components/add_trenches.py 100.00% <100.00%> (+13.33%) ⬆️
gdsfactory/components/array_with_fanout.py 100.00% <100.00%> (ø)
gdsfactory/components/awg.py 100.00% <100.00%> (ø)
... and 143 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 79423ef into main Sep 25, 2023
8 checks passed
@joamatab joamatab deleted the gdsfactory78 branch September 25, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid snapping fixes
1 participant