Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbox does not extend beyond ports in bends #2154

Merged
merged 1 commit into from Oct 3, 2023
Merged

bbox does not extend beyond ports in bends #2154

merged 1 commit into from Oct 3, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Oct 3, 2023

fixes #2134

@LuYouxi

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2154 (a87c575) into main (90116d6) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   71.82%   71.84%   +0.01%     
==========================================
  Files         367      367              
  Lines       23052    23062      +10     
  Branches     3394     3394              
==========================================
+ Hits        16557    16568      +11     
+ Misses       5445     5444       -1     
  Partials     1050     1050              
Files Coverage Δ
gdsfactory/components/bend_circular.py 100.00% <100.00%> (ø)
gdsfactory/components/bend_euler.py 72.41% <100.00%> (+0.64%) ⬆️
gdsfactory/components/straight.py 100.00% <100.00%> (ø)
gdsfactory/components/bend_circular_heater.py 96.77% <91.66%> (+4.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 9cc50d4 into main Oct 3, 2023
8 checks passed
@joamatab joamatab deleted the fix_bbox branch October 3, 2023 13:56
@LuYouxi
Copy link

LuYouxi commented Oct 3, 2023

hi, I saw the modification of the straight waveguide and bend waveguide codes, but the offset parameter of bbox did not work, and the waveguide with bbox is still the same as version 7.8.0. I guess the implementation of add_bbox in cross_section should also be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the bug for CrossSection with bbox
2 participants