Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap detector to 2x grid #2314

Merged
merged 1 commit into from Nov 15, 2023
Merged

snap detector to 2x grid #2314

merged 1 commit into from Nov 15, 2023

Conversation

joamatab
Copy link
Contributor

fixes some DRC errors when adding grating couplers, if length is centered at zero, the lenghts need of the polygon need to snap to 2nm grid

@joamatab joamatab requested a review from mdecea November 15, 2023 21:49
@joamatab joamatab merged commit e2b99f1 into main Nov 15, 2023
7 checks passed
@joamatab joamatab deleted the snap_coupler_2x_grid branch November 15, 2023 21:51
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af83018) 72.64% compared to head (4643bab) 72.64%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2314   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files         368      368           
  Lines       23064    23065    +1     
  Branches     3718     3718           
=======================================
+ Hits        16755    16756    +1     
  Misses       5208     5208           
  Partials     1101     1101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant