Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pins in taper_cross_section #2330

Merged
merged 1 commit into from Nov 28, 2023

Conversation

nikosavola
Copy link
Member

This PR

  • modifies taper_cross_section to add pins if possible
  • handles partialed tapers in gdsfactory/add_tapers_cross_section.py to not overwrite given cross_section2 if None

@nikosavola nikosavola self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ddd5647) 72.64% compared to head (d22399d) 72.63%.

Files Patch % Lines
gdsfactory/add_tapers_cross_section.py 20.00% 4 Missing ⚠️
gdsfactory/components/taper_cross_section.py 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   72.64%   72.63%   -0.02%     
==========================================
  Files         368      368              
  Lines       23066    23073       +7     
  Branches     3719     3722       +3     
==========================================
+ Hits        16757    16759       +2     
- Misses       5208     5211       +3     
- Partials     1101     1103       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosavola nikosavola marked this pull request as ready for review November 28, 2023 03:39
@joamatab joamatab merged commit 90dae97 into main Nov 28, 2023
7 of 9 checks passed
@joamatab joamatab deleted the add_tapers_support_taper_cross_section branch November 28, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants