Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add round_corners_east_west and round_corners_north_south to rectangle #2349

Merged
merged 2 commits into from Dec 3, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Dec 3, 2023

No description provided.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f3edf0c) 72.67% compared to head (aea1e80) 72.61%.
Report is 6 commits behind head on main.

Files Patch % Lines
gdsfactory/components/rectangle.py 13.04% 16 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
- Coverage   72.67%   72.61%   -0.07%     
==========================================
  Files         369      369              
  Lines       23131    23153      +22     
  Branches     3735     3739       +4     
==========================================
+ Hits        16811    16813       +2     
- Misses       5218     5234      +16     
- Partials     1102     1106       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 90985c3 into main Dec 3, 2023
7 of 9 checks passed
@joamatab joamatab deleted the add_rectangle_round_corners branch December 3, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant