Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend pip instead of conda for installation #2433

Merged
merged 2 commits into from Jan 3, 2024
Merged

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jan 3, 2024

  • Recommend pip instead of conda for installation
  • deprecate plot_kweb and plot_matplotlib
  • move most dependencies from pip install gdsfactory[cad] into pip install gdsfactory

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (de8ca20) 72.64% compared to head (0565916) 72.64%.

Files Patch % Lines
gdsfactory/component.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2433      +/-   ##
==========================================
- Coverage   72.64%   72.64%   -0.01%     
==========================================
  Files         366      366              
  Lines       23260    23261       +1     
  Branches     3787     3787              
==========================================
  Hits        16897    16897              
- Misses       5235     5236       +1     
  Partials     1128     1128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit f653949 into main Jan 3, 2024
8 of 10 checks passed
@joamatab joamatab deleted the recommend_pip branch January 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant