Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better naming #2434

Merged
merged 11 commits into from Jan 9, 2024
Merged

better naming #2434

merged 11 commits into from Jan 9, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jan 3, 2024

avoid even when users don't use decorator to not create duplicated cell names so we can use the name as a component unique id and avoid slow geometric hashes

fixes #2435

@yaugenst
@tvt173
@nikosavola
@flaport

@joamatab joamatab requested a review from tvt173 January 3, 2024 07:44
@joamatab
Copy link
Contributor Author

joamatab commented Jan 4, 2024

this seems PR seems to have issues with components that use flatten_invalid_refs

See for example gf.components.coupler_bent
image

@joamatab joamatab added the help wanted Extra attention is needed label Jan 4, 2024
@tvt173
Copy link
Collaborator

tvt173 commented Jan 9, 2024

see the alternative branch, which is now working #2453

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a14a526) 72.59% compared to head (ac75a3a) 72.59%.
Report is 6 commits behind head on main.

Files Patch % Lines
gdsfactory/component.py 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2434   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files         366      366           
  Lines       23308    23327   +19     
  Branches     3788     3794    +6     
=======================================
+ Hits        16920    16935   +15     
- Misses       5266     5267    +1     
- Partials     1122     1125    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab
Copy link
Contributor Author

joamatab commented Jan 9, 2024

Thank you Troy, i brought your improvements here

i prefer this PR because gf.Component() has a safer init name with the counter on it

@joamatab
Copy link
Contributor Author

joamatab commented Jan 9, 2024

for some weird reason tests now fail in macOs but pass on linux

https://github.com/gdsfactory/gdsfactory/actions/runs/7459521790/job/20295712487

@joamatab joamatab merged commit 7dce9ac into main Jan 9, 2024
9 checks passed
@joamatab joamatab deleted the better_naming branch January 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hash geometry creates segfaults for big gds files
2 participants