New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better naming #2434
better naming #2434
Conversation
see the alternative branch, which is now working #2453 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 366 366
Lines 23308 23327 +19
Branches 3788 3794 +6
=======================================
+ Hits 16920 16935 +15
- Misses 5266 5267 +1
- Partials 1122 1125 +3 ☔ View full report in Codecov by Sentry. |
Thank you Troy, i brought your improvements here i prefer this PR because gf.Component() has a safer init name with the counter on it |
for some weird reason tests now fail in macOs but pass on linux https://github.com/gdsfactory/gdsfactory/actions/runs/7459521790/job/20295712487 |
avoid even when users don't use decorator to not create duplicated cell names so we can use the name as a component unique id and avoid slow geometric hashes
fixes #2435
@yaugenst
@tvt173
@nikosavola
@flaport