Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grid snaping docs, functions and names #2446

Merged
merged 6 commits into from Jan 7, 2024
Merged

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jan 7, 2024

  • snap path extrusion and transition, and add docs for snapping
  • movement of paths and polygons snaps movements to grid to avoid 1nm gaps
  • add tutorial on grid_snapping issues and fixes
  • rename enable_ports_off_grid to enable_ports_offgrid to be consistent, deprecate the old one

@yaugenst
@simbilod
@mdecea
@nikosavola
@HelgeGehring
@tvt173

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e94d5fa) 72.55% compared to head (498f0bd) 72.59%.
Report is 1 commits behind head on main.

Files Patch % Lines
gdsfactory/config.py 75.00% 4 Missing ⚠️
gdsfactory/cell.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2446      +/-   ##
==========================================
+ Coverage   72.55%   72.59%   +0.04%     
==========================================
  Files         366      366              
  Lines       23289    23306      +17     
  Branches     3789     3789              
==========================================
+ Hits        16898    16920      +22     
  Misses       5264     5264              
+ Partials     1127     1122       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab changed the title Improve grid snaping Improve grid snaping docs, functions and names Jan 7, 2024
@joamatab joamatab merged commit bb08acc into main Jan 7, 2024
10 checks passed
@joamatab joamatab deleted the improve_grid_snaping branch January 7, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant