Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test warnings #2455

Merged
merged 1 commit into from Jan 9, 2024
Merged

remove test warnings #2455

merged 1 commit into from Jan 9, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jan 9, 2024

  • remove test warnings

@joamatab
Copy link
Contributor Author

joamatab commented Jan 9, 2024

For some reason tests on MacOs seem to fail in some cases and pass in other cases

https://github.com/gdsfactory/gdsfactory/actions/runs/7459812044

@tvt173

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f992c18) 72.59% compared to head (989be14) 72.59%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2455   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files         366      366           
  Lines       23327    23327           
  Branches     3794     3794           
=======================================
  Hits        16935    16935           
  Misses       5267     5267           
  Partials     1125     1125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 0592793 into main Jan 9, 2024
9 checks passed
@joamatab joamatab deleted the remove_test_warnings branch January 9, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant