Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize output for variable width/offsets in Section and CrossSection #2466

Merged
merged 4 commits into from Jan 12, 2024

Conversation

thomasdorch
Copy link
Contributor

Fixes #2465

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e6cc1c) 72.59% compared to head (513c327) 72.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2466      +/-   ##
==========================================
+ Coverage   72.59%   72.60%   +0.01%     
==========================================
  Files         366      366              
  Lines       23330    23343      +13     
  Branches     3794     3800       +6     
==========================================
+ Hits        16936    16949      +13     
  Misses       5269     5269              
  Partials     1125     1125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab self-requested a review January 12, 2024 19:10
Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you Thomas!

@joamatab joamatab merged commit cb696a4 into gdsfactory:main Jan 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization for Transition & Section doesn't always work for variable widths
2 participants