Component reduce #2480
Merged
Component reduce #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
+ Coverage 72.55% 72.57% +0.01%
==========================================
Files 366 366
Lines 23367 23381 +14
Branches 3807 3807
==========================================
+ Hits 16954 16968 +14
Misses 5286 5286
Partials 1127 1127 ☔ View full report in Codecov by Sentry. |
simbilod
commented
Jan 21, 2024
|
|
||
| # Component functions | ||
| def serialize_gds(component): | ||
| """Saves Component as GDS + YAML metadata in temporary files with unique name.""" | ||
| gds_filepath = GDSDIR_TEMP / component.name |
There was a problem hiding this comment.
@joamatab should this use something else than the name to guarantee there are no collisions?
There was a problem hiding this comment.
I think name is the best we can use :)
joamatab
approved these changes
Jan 21, 2024
|
|
||
| # Component functions | ||
| def serialize_gds(component): | ||
| """Saves Component as GDS + YAML metadata in temporary files with unique name.""" | ||
| gds_filepath = GDSDIR_TEMP / component.name |
There was a problem hiding this comment.
I think name is the best we can use :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the "reduce" built-in method in Component to allow pickling. This is useful when integrating gdsfactory/gplugins with libraries that use pickling to move data around
@joamatab I'm not sure about this one because there's a lot going with the caching/serialization in gdsfactory. I tried using json and yaml serialization, but it didn't work as well as gds + metadata like I do now.
I don't really care how it's done, I just want to fix the "gdstk.Cell not serializable" errors we get when we try to pickle Components, and I just want a component similar in structure to be returned (I don't really care about unique IDs and such since this is for simulation, not layout)