Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding possibilty of different bends in 2x2 cutback #2485

Merged
merged 1 commit into from Jan 24, 2024

Conversation

mdecea
Copy link
Collaborator

@mdecea mdecea commented Jan 24, 2024

In the 2x2 cutbacks, if we use the same 180 degree bend for both ports we might end up with waveguides too close to each other:

image

This PR allows to use different bends for each port. This way we can separate the waveguides form each other, for example using a circular and an Euler bend:

image

@mdecea mdecea requested a review from joamatab January 24, 2024 19:10
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fa42520) 72.55% compared to head (f45b9e1) 72.55%.

Files Patch % Lines
gdsfactory/components/cutback_2x2.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2485      +/-   ##
==========================================
- Coverage   72.55%   72.55%   -0.01%     
==========================================
  Files         366      366              
  Lines       23385    23389       +4     
  Branches     3809     3810       +1     
==========================================
+ Hits        16968    16969       +1     
- Misses       5290     5292       +2     
- Partials     1127     1128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you Marc

@joamatab joamatab merged commit 762f480 into gdsfactory:main Jan 24, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants