Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export metadata as json #2487

Merged
merged 1 commit into from Jan 27, 2024
Merged

export metadata as json #2487

merged 1 commit into from Jan 27, 2024

Conversation

flaport
Copy link
Collaborator

@flaport flaport commented Jan 27, 2024

using write_gds(with_metadata=True) and import_gds(read_metadata=True) is very slow for large PICs. I've added additional flags write_gds(with_metadata_json=...) and import_gds(read_metadata_json=...) that exports the metadata to json and writes/reads the json with orjson. This is orders of magnitude faster than the yaml write/read.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (faf6f4e) 72.55% compared to head (134384a) 72.48%.

Files Patch % Lines
gdsfactory/read/import_gds.py 10.52% 16 Missing and 1 partial ⚠️
gdsfactory/component.py 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
- Coverage   72.55%   72.48%   -0.07%     
==========================================
  Files         366      366              
  Lines       23389    23413      +24     
  Branches     3810     3821      +11     
==========================================
+ Hits        16969    16972       +3     
- Misses       5292     5311      +19     
- Partials     1128     1130       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab self-requested a review January 27, 2024 02:35
@joamatab joamatab merged commit 2f2a229 into main Jan 27, 2024
5 of 9 checks passed
@joamatab joamatab deleted the metadata-json branch January 27, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants