Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add post process to more pcells #2524

Merged
merged 3 commits into from Feb 14, 2024
Merged

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Feb 12, 2024

@HelgeGehring
@sebastian-goeldi
@nikosavola
@tvt173

Could we do this in the cell decorator?
this would simplify the definition of the cell

This would need to be supported by kfactory as well if implemented

@github-actions github-actions bot added the enhancement New feature or request label Feb 12, 2024
@tvt173
Copy link
Collaborator

tvt173 commented Feb 13, 2024

i don't know how you plan to manage this with your flow, but i would generally agree that either doing it as a decorator or actually "post processing" the GDS after it is output would be better.

@sebastian-goeldi
Copy link
Collaborator

In kfactory the easiest way I see is this gdsfactory/kfactory#249

@joamatab
Copy link
Contributor Author

this can be used for adding info, padding, or LVS marker layers that are different for each type of container

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d48d75e) 72.39% compared to head (51a35fb) 72.36%.
Report is 6 commits behind head on main.

Files Patch % Lines
gdsfactory/components/coupler.py 33.33% 1 Missing and 1 partial ⚠️
gdsfactory/components/resistance_sheet.py 33.33% 1 Missing and 1 partial ⚠️
gdsfactory/components/triangles.py 33.33% 1 Missing and 1 partial ⚠️
gdsfactory/components/via_stack.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
- Coverage   72.39%   72.36%   -0.03%     
==========================================
  Files         366      366              
  Lines       23640    23647       +7     
  Branches     3872     3876       +4     
==========================================
- Hits        17114    17113       -1     
- Misses       5361     5365       +4     
- Partials     1165     1169       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit e60feff into main Feb 14, 2024
11 of 13 checks passed
@joamatab joamatab deleted the add_post_process_to_more_pcells branch February 14, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants