Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of specifying offset in add_fiber_array #2543

Merged
merged 1 commit into from Feb 16, 2024

Conversation

mdecea
Copy link
Collaborator

@mdecea mdecea commented Feb 16, 2024

Adds offset to add_labels

@mdecea mdecea requested a review from joamatab February 16, 2024 22:45
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a217808) 72.15% compared to head (795bcde) 72.15%.

Files Patch % Lines
gdsfactory/routing/add_fiber_array.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   72.15%   72.15%           
=======================================
  Files         366      366           
  Lines       23720    23720           
  Branches     3909     3909           
=======================================
  Hits        17116    17116           
  Misses       5419     5419           
  Partials     1185     1185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab changed the title Possibility of specifying offset Possibility of specifying offset in add_fiber_array Feb 16, 2024
@joamatab joamatab merged commit 3bd5139 into gdsfactory:main Feb 16, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants