Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling top and bottom GC routing #2560

Merged
merged 1 commit into from Feb 26, 2024
Merged

Handling top and bottom GC routing #2560

merged 1 commit into from Feb 26, 2024

Conversation

mdecea
Copy link
Collaborator

@mdecea mdecea commented Feb 26, 2024

Modifies route_fiber_array to be able to handle simple situations were there are ports at the top and bottom.

Before this PR, we would have situations like this:
image

With the PR, such a situation is solved (when using optical_routing_type=0:

image

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.85%. Comparing base (4a66ed9) to head (33a1cac).

Files Patch % Lines
gdsfactory/routing/route_fiber_array.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2560      +/-   ##
==========================================
- Coverage   71.86%   71.85%   -0.01%     
==========================================
  Files         367      367              
  Lines       23814    23816       +2     
  Branches     3929     3930       +1     
==========================================
  Hits        17114    17114              
- Misses       5501     5502       +1     
- Partials     1199     1200       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab added the maintenance patch label Feb 26, 2024
@joamatab joamatab self-requested a review February 26, 2024 18:37
@joamatab joamatab merged commit 887cdb1 into gdsfactory:main Feb 26, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants