Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix taper #2575

Merged
merged 2 commits into from Mar 2, 2024
Merged

fix taper #2575

merged 2 commits into from Mar 2, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Mar 2, 2024

  • fixes taper rib

before slab was missing from the taper

image

after the fix

image

@github-actions github-actions bot added the bug Something isn't working label Mar 2, 2024
@joamatab joamatab added the maintenance patch label Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.81%. Comparing base (f239e6d) to head (499ef17).

Files Patch % Lines
...sfactory/components/grating_coupler_rectangular.py 16.66% 4 Missing and 1 partial ⚠️
gdsfactory/components/taper.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2575      +/-   ##
==========================================
- Coverage   71.84%   71.81%   -0.03%     
==========================================
  Files         368      368              
  Lines       23904    23911       +7     
  Branches     3947     3948       +1     
==========================================
- Hits        17173    17171       -2     
- Misses       5521     5529       +8     
- Partials     1210     1211       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit e3a7689 into main Mar 2, 2024
11 of 13 checks passed
@joamatab joamatab deleted the fix_taper_rib branch March 2, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant